Comment by Lundin on State-machine class based upon arduino toolchain
@bask185 I interact with hundreds of people on the SE network each week. I have no idea who you are and have no "past" with you. And regardless, stubbornly refusing to adopt what's widely considered...
View ArticleComment by Lundin on A beginner's implementation of tic-tac-toe
@chux-ReinstateMonica C17 6.11.6 "The use of function declarators with empty parentheses (not prototype-format parameter type declarators) is an obsolescent feature."
View ArticleComment by Lundin on A beginner's implementation of tic-tac-toe
@chux-ReinstateMonica It's somewhat common coding style to use capital letters for constants, not just for macros.
View ArticleComment by Lundin on Concept of implementing "generic" types in C using macros
@JohnKimble There's both better type safety and less layers in-between this way. Though if you wish to implement some C++ vector-like container, there's probably no sensible way to avoid dynamic memory...
View ArticleComment by Lundin on touch command in C
The most correct fix is rather to input sanitize argv. Can be as easy as a memchr search for \0. Then you need not concern yourself with potential overflows later on.
View ArticleComment by Lundin on Portable noreturn in C/C++ between compilers
"this is intended to be portable all C and C++ standards" I don't think that's possible since the feature wasn't present back in the days. Well-written, modern code uses stdnoreturn.h and does not rely...
View ArticleComment by Lundin on Standard C overflow-safe arithmetic functions
Never use mysterious crap types over standardized integer types. Every single #define in this code needs to go.
View ArticleComment by Lundin on Standard C overflow-safe arithmetic functions
Good review, I strongly agree with everything said.
View ArticleComment by Lundin on Function to skip characters
Many aren't aware of the standard strcspn function. It returns the length of a string until the point where one out of several characters has been found. size_t i = strcspn(str, " \t\r\n"); /* whatever...
View ArticleComment by Lundin on C string parser criticism
@user1593842 Because you say so or because of actual arguments?
View ArticleAnswer by Lundin for Trigraph translator
There is absolutely no reason why WRITE_BUFFER should be a macro and not a function.Don't do exotic stuff like --argc; ++argv;. C programmers expect argument 0 to be the name of the executable....
View ArticleAnswer by Lundin for Double-ended queue for Embedded Systems with different...
Couple of bugs:queue.c doesn't #include <string.h>.Casting the pointer parameters passed to memset and memcpy isn't necessary, but can hide bugs.Your macros do non-standard pointer arithmetic on...
View ArticleAnswer by Lundin for Simple state machine
Implementing state machines with a table with function pointers is very common. The table should however be read-only and preferably stored in flash. This does however seem to be some PC-like ARM with...
View ArticleAnswer by Lundin for Statically allocated memory pool in C for embedded systems
Design:Consider making an API that enforces the caller to allocate aligned chunks. This will make the code much more robust on 32 bit systems. You can still let them state the desired size in bytes,...
View ArticleAnswer by Lundin for Generic Vector implemented in C language
Design:Overall, function naming and const correctness etc looks good. The header is nicely formatted and easy to read. Most function names are self-explanatory, though I wouldn't use start and...
View ArticleAnswer by Lundin for Calculate the free electron concentration and drift...
In addition to the other reviews, some misc comments:The switch RUN_REAL_PROGRAM is weird, doesn't seem like something that should be part of the final program - remove it.In general, avoid...
View ArticleAnswer by Lundin for case-insensitive `strncmp()` for ASCII chars only (not...
Overall, checking byte by byte is fast on 8/16 bit CPUs since they typically don't care about alignment, but slow on 32 bit or larger CPUs. So the byte by byte loop is fine if low-end MCUs are the...
View ArticleAnswer by Lundin for Simple Tetris game
Always write source code and comments in English (I'm not a native English speaker either). You will sooner or later need to share code with other people around the world, like you just did here and...
View ArticleAnswer by Lundin for Remove all comments from a C program
First a classic bug: char cur_char; ... (cur_char = getchar()) != EOF. The variable must be int not char or you can't compare it with EOF. Yeah it's really stupid that getchar gets an int, not a char,...
View Article